fix: upgrade proxy-agent to ^6.3.0 to remove vm2 deps #13012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsluja
commented
Jul 26, 2023
yarn.lock
Outdated
| @@ -31455,18 +31474,6 @@ node-pty@beta: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "vm2@npm:^3.9.3": | |||
There was a problem hiding this comment.
vm2 removal is here
sobolk
previously approved these changes
Jul 26, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #13012 +/- ##
===========================================
+ Coverage 0.00% 48.40% +48.40%
===========================================
Files 1296 841 -455
Lines 149743 38033 -111710
Branches 1296 7789 +6493
===========================================
+ Hits 0 18408 +18408
+ Misses 148447 18032 -130415
- Partials 1296 1593 +297
... and 1229 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sobolk
approved these changes
Jul 27, 2023
jhockett
reviewed
Jul 27, 2023
jhockett
approved these changes
Jul 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
E2e run https://tiny.amazon.com/1gmqt246c/IsenLink
This removes the last of the vm2 dependencies by upgrading proxy-agent.
Proxy agent constructor has changed since v5, so there were updates as well.
See proxy-agent docs here: https://github.com/TooTallNate/proxy-agents/tree/main/packages/proxy-agent
Proxy-agent uses this module to determine which proxy to use, so we don't need to manually specify http/https anymore, see:
https://www.npmjs.com/package/proxy-from-env
https://www.npmjs.com/package/proxy-from-env#environment-variables
We do still need to conditionally check if proxy vars are set to decide if we want to initialize a new proxyagent.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.